Skip to content

Commit

Permalink
Skip . and $ in section name for subsections when an empty name is given
Browse files Browse the repository at this point in the history
So rather than producing .text. it now produces .text
  • Loading branch information
bjorn3 committed Dec 5, 2024
1 parent 2b9db57 commit d18874e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions src/write/coff/object.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,10 @@ impl<'a> Object<'a> {

pub(crate) fn coff_subsection_name(&self, section: &[u8], value: &[u8]) -> Vec<u8> {
let mut name = section.to_vec();
name.push(b'$');
name.extend_from_slice(value);
if !value.is_empty() {
name.push(b'$');
name.extend_from_slice(value);
}
name
}

Expand Down
6 changes: 4 additions & 2 deletions src/write/elf/object.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ impl<'a> Object<'a> {

pub(crate) fn elf_subsection_name(&self, section: &[u8], value: &[u8]) -> Vec<u8> {
let mut name = section.to_vec();
name.push(b'.');
name.extend_from_slice(value);
if !value.is_empty() {
name.push(b'.');
name.extend_from_slice(value);
}
name
}

Expand Down

0 comments on commit d18874e

Please sign in to comment.