Don't fail if unable to read the string for DW_AT_comp_dir or DW_AT_name #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behaviour of llvm-dwarfdump: e.g. dwarf::toString(UnitDie.find(DW_AT_comp_dir)) just returns an Optional and doesn't fail. Fixes gimli-rs#514
|
I think this change is good, but I'm also curious why we are unable to read those strings. Is there another bug causing that? |
|
I think offsets are outside of the file. We get an |
|
The value in |
This was referenced Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the behaviour of llvm-dwarfdump:
e.g. dwarf::toString(UnitDie.find(DW_AT_comp_dir)) just returns an
Optional and doesn't fail.
Fixes #514