Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UninitializedUnwindContext::initialize to borrow #395

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Change UninitializedUnwindContext::initialize to borrow #395

merged 1 commit into from
Mar 1, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Mar 1, 2019

This results in simpler code for users, with just as much safety.

@philipc
Change UninitializedUnwindContext::initialize to borrow
1ed925e 
This results in simpler code for users, with just as much safety.
@philipc philipc requested a review from fitzgen March 1, 2019 10:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 86.573% when pulling 1ed925e on philipc:unwind-context into 7b828cb on gimli-rs:master.

fitzgen
fitzgen approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice API clean up!

@fitzgen fitzgen merged commit 039e042 into gimli-rs:master Mar 1, 2019
@philipc philipc deleted the unwind-context branch March 2, 2019 01:22
@philipc philipc mentioned this pull request Mar 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipc @coveralls @fitzgen