Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
philipc committed Jan 15, 2019
1 parent 725d0a2 commit 280863c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/read/addr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ mod tests {

#[test]
fn test_get_address() {
for format in [Format::Dwarf32, Format::Dwarf64].iter().cloned() {
for address_size in [4, 8].iter().cloned() {
for format in vec![Format::Dwarf32, Format::Dwarf64] {
for address_size in vec![4, 8] {
let zero = Label::new();
let length = Label::new();
let start = Label::new();
Expand Down
2 changes: 1 addition & 1 deletion src/read/loclists.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,7 @@ mod tests {

#[test]
fn test_get_offset() {
for format in [Format::Dwarf32, Format::Dwarf64].iter().cloned() {
for format in vec![Format::Dwarf32, Format::Dwarf64] {
let zero = Label::new();
let length = Label::new();
let start = Label::new();
Expand Down
2 changes: 1 addition & 1 deletion src/read/reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ pub trait Reader: Debug + Clone {
/// Does not advance the reader.
fn to_string_lossy(&self) -> Result<Cow<str>>;

/// Read a u8 slice.
/// Read exactly `buf.len()` bytes into `buf`.
fn read_slice(&mut self, buf: &mut [u8]) -> Result<()>;

/// Read a u8 array.
Expand Down
2 changes: 1 addition & 1 deletion src/read/rnglists.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ mod tests {

#[test]
fn test_get_offset() {
for format in [Format::Dwarf32, Format::Dwarf64].iter().cloned() {
for format in vec![Format::Dwarf32, Format::Dwarf64] {
let zero = Label::new();
let length = Label::new();
let start = Label::new();
Expand Down
2 changes: 1 addition & 1 deletion src/read/str.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ mod tests {

#[test]
fn test_get_str_offset() {
for format in [Format::Dwarf32, Format::Dwarf64].iter().cloned() {
for format in vec![Format::Dwarf32, Format::Dwarf64] {
let zero = Label::new();
let length = Label::new();
let start = Label::new();
Expand Down

0 comments on commit 280863c

Please sign in to comment.