Add support to read/write space-padded fixed-length strings #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kept this separate from #377 in case you only want that fix (and not this feature), but if you wish I can both changes on your last master and offer a single pull request with both things. |
gijzelaerr
requested changes
Aug 3, 2022
59cfd2c to
0756e5f
Compare
these strings are not part of the official s7comm specification, but they are commonly found in real-world systems. they simply consist of a byte array that contains characters forming a string, padded on the right with spaces (ascii 32) when the string length is shorter than the array. this commit adds support for reading and writing, as well as usage in tables (snap7.util.DB), and unit tests.
|
I have made the requested change as well as fixed the reported linting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in issue #375, I'm offering this PR with the modifications we are using internally to support the datatype.
A recap of what this is, adapted from the commit message:
These strings are not part of the official s7comm specification, but
they are commonly found in real-world systems. They simply consist of a
byte array that contains characters forming a string, padded on the
right with spaces (ascii 32) when the string length is shorter than the
array.
This commit adds support for reading and writing, as well as usage in
tables (snap7.util.DB), and unit tests.