Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update read_multi.py #132

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Update read_multi.py #132

merged 1 commit into from
Oct 29, 2019

Conversation

edsase
Copy link
Contributor

@edsase edsase commented Oct 5, 2019

There was an error in the original code for extracting the read values. Line 64 foo = ''.join([chr(di.pData[i]) for i in range(0, di.Amount)]) always breaks. Replaced code block from line 57-66 with similar code block on test_client.py

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   78.91%   78.91%           
=======================================
  Files          15       15           
  Lines        2092     2092           
=======================================
  Hits         1651     1651           
  Misses        441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4660357...119f2ef. Read the comment docs.

@gijzelaerr gijzelaerr merged commit b28e9d7 into gijzelaerr:master Oct 29, 2019
@gijzelaerr gijzelaerr added this to the 0.11 milestone Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants