Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some client tests segfault on Linux #26

Closed
gijzelaerr opened this issue Jul 27, 2014 · 5 comments
Closed

Some client tests segfault on Linux #26

gijzelaerr opened this issue Jul 27, 2014 · 5 comments
Milestone

Comments

@gijzelaerr
Copy link
Owner

But they don't on OSX and windows.

Not sure why. for example:

  • test_ab_write
  • test_as_ab_read
  • test_as_ab_write
@gijzelaerr gijzelaerr added the bug label Jul 27, 2014
@gijzelaerr gijzelaerr self-assigned this Jul 27, 2014
@gijzelaerr gijzelaerr added this to the 0.4 milestone Jul 27, 2014
@gijzelaerr gijzelaerr modified the milestones: 0.5, 0.4 Oct 11, 2014
@gijzelaerr gijzelaerr removed their assignment Jan 14, 2015
@gijzelaerr gijzelaerr modified the milestones: 0.5, 0.6 Aug 29, 2015
@gijzelaerr gijzelaerr modified the milestones: 0.6, 1.0 May 12, 2016
@ellepdesk
Copy link
Contributor

I think this is caused by this bug in Snap7, using the patch suggested the unittest no longer segfault when un-skipped.

ellepdesk added a commit to ellepdesk/snap7 that referenced this issue Feb 27, 2017
Bug report for Snap7
https://sourceforge.net/p/snap7/tickets/7/

Bug report for python-snap7, which consistently fails without this patch
gijzelaerr/python-snap7#26
@gijzelaerr
Copy link
Owner Author

interesting, thanks for letting me know!

@gijzelaerr
Copy link
Owner Author

Now going trough this I guess it is related to:

#164

where we try to read out garbage values which are not ready yet. The ab read functions should be modified to not convert the results and proper documentation should be added

@swamper123
Copy link
Contributor

I guess most of the as-methods have to return a pointer and have to been checked/handled by one of the mentioned "check" methods (not implemented yet). There will be a PR either next - or after next week for that. Perhaps using wait_as_completion to check completion in as_tests would be the easiest one and asyncio wouldn't be mandatory.

@gijzelaerr
Copy link
Owner Author

i think we just know by now that is caused by improper usage of the as functions, so we can close this issue.

@gijzelaerr gijzelaerr removed this from the 0.12 milestone Jan 7, 2021
@gijzelaerr gijzelaerr added this to the 1.0 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants