Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set root user for k8s-kubelet explicitly (v7) #824

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Set root user for k8s-kubelet explicitly (v7) #824

merged 2 commits into from
Oct 30, 2020

Conversation

corest
Copy link
Contributor

@corest corest commented Oct 30, 2020 •
edited
Loading

Checklist

  • Update changelog in CHANGELOG.md.

@corest corest requested a review from a team October 30, 2020 09:45
@corest corest mentioned this pull request Oct 30, 2020
Closed
1 task
kopiczko
kopiczko reviewed Oct 30, 2020
View reviewed changes
pkg/template/master_template.go
@@ -293,6 +293,7 @@ systemd:
Description=k8s-kubelet
StartLimitIntervalSec=0
[Service]
User=root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if you don't specify it what is the user running the service?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still the root. But without HOME env variable. Here it is explained kubernetes/kubernetes#45487 (comment)

@corest corest changed the title Set root user for k8s-kubelet explicitly Set root user for k8s-kubelet explicitly (v7) Oct 30, 2020
@corest corest merged commit d1d0e49 into release-v7.1.x Oct 30, 2020
@corest corest deleted the explicit-root-user branch October 30, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kopiczko kopiczko kopiczko left review comments

@kubasobon kubasobon kubasobon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corest @kubasobon @kopiczko