Bumping app package (#1341)

* Bumping app package * Bumping app further * Updating app package * Bumping app package to v7.0.4 * Fixing names
giantswarm · Jan 30, 2025 · b4afcd1 · b4afcd1
1 parent 2589e51
commit b4afcd1
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s
 
 ## [Unreleased]
 
+### Fixed
+
+- Bump the `github.com/giantswarm/app` package to version `v7.0.4` which prevents creation of empty Secrets for Chart CRs.
+
 ## [7.0.0] - 2024-11-19
 
 ### Removed

diff --git a/go.mod b/go.mod
@@ -8,7 +8,7 @@ require (
 	github.com/Masterminds/semver/v3 v3.3.1
 	github.com/ghodss/yaml v1.0.0
 	github.com/giantswarm/apiextensions-application v0.6.2
-	github.com/giantswarm/app/v7 v7.0.3
+	github.com/giantswarm/app/v7 v7.0.4
 	github.com/giantswarm/appcatalog v1.0.0
 	github.com/giantswarm/apptest v1.4.1
 	github.com/giantswarm/backoff v1.0.1

diff --git a/go.sum b/go.sum
@@ -131,8 +131,8 @@ github.com/ghodss/yaml v1.0.0 h1:wQHKEahhL6wmXdzwWG11gIVCkOv05bNOh+Rxn0yngAk=
 github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
 github.com/giantswarm/apiextensions-application v0.6.2 h1:XL86OrpprWl5Wp38EUvUXt3ztTo25+V63oDVlFwDpNg=
 github.com/giantswarm/apiextensions-application v0.6.2/go.mod h1:8ylqSmDSzFblCppRQTFo8v9s/F6MX6RTusVVoDDfWso=
-github.com/giantswarm/app/v7 v7.0.3 h1:2xMGts4kAkKHo4tUC8Golm3j/kAlUeQjAw5WpRkoz4w=
-github.com/giantswarm/app/v7 v7.0.3/go.mod h1:1xA1ddQzNMgPcf8VdQLn3Ohm2ww4z1ARSujirdFXz3U=
+github.com/giantswarm/app/v7 v7.0.4 h1:JBFKsUKhxtbduPVdBHjhGclg+czK7N7ITx4e3s9s4oQ=
+github.com/giantswarm/app/v7 v7.0.4/go.mod h1:szBwpNxf8NcxEGgmR+3ljEJEdKqe3Mfy5IcY5TEyf+s=
 github.com/giantswarm/appcatalog v1.0.0 h1:h2vNqd53ciYenoB04nrit4zruG4TeWiNT28t94l0wkw=
 github.com/giantswarm/appcatalog v1.0.0/go.mod h1:KmzfEU2sLoXldJ2OaAY6Pn/78h2wmfZqMwjRYQkudSo=
 github.com/giantswarm/apptest v1.4.1 h1:9GEVbB8Zvb/EdRXcmc2zWebs0TQ4pZrJ7W5XjnpDJS8=

diff --git a/service/controller/app/resource/secret/delete.go b/service/controller/app/resource/secret/delete.go
@@ -31,7 +31,7 @@ func (r *Resource) ApplyDeleteChange(ctx context.Context, obj, deleteChange inte
 		} else if err != nil {
 			return microerror.Mask(err)
 		} else {
-			r.logger.Debugf(ctx, "deleted Chart CR %#q in namespace %#q", secret.Name, secret.Namespace)
+			r.logger.Debugf(ctx, "deleted secret %#q in namespace %#q", secret.Name, secret.Namespace)
 		}
 	}
 

diff --git a/service/watcher/chartstatus/chartstatus.go b/service/watcher/chartstatus/chartstatus.go
@@ -163,7 +163,7 @@ func (c *ChartStatusWatcher) watchChartStatus(ctx context.Context) {
 				types.NamespacedName{Name: appName, Namespace: appNamespace},
 				&app)
 			if err != nil {
-				c.logger.Errorf(ctx, err, "failed to get app '%s/%s'", app.Namespace, app.Name)
+				c.logger.Errorf(ctx, err, "failed to get app '%s/%s'", appNamespace, appName)
 				continue
 			}