Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1276: [AIX] use getargs to get process cmdline #1500

Merged
merged 2 commits into from
May 6, 2019
Merged

Fix #1276: [AIX] use getargs to get process cmdline #1500

merged 2 commits into from
May 6, 2019

Conversation

wiggin15
Copy link
Collaborator

@wiggin15 wiggin15 commented Apr 30, 2019 •
edited by giampaolo
Loading

Fixes #1276.

giampaolo
giampaolo requested changes May 1, 2019
View reviewed changes
psutil/_psaix.py Outdated Show resolved Hide resolved
psutil/_psaix.py Outdated Show resolved Hide resolved
psutil/_psutil_aix.c Outdated Show resolved Hide resolved
psutil/tests/test_process.py Show resolved Hide resolved
psutil/_psaix.py Outdated Show resolved Hide resolved
@wiggin15
Copy link
Collaborator Author

wiggin15 commented May 1, 2019

Updated PR

giampaolo
giampaolo approved these changes May 1, 2019
View reviewed changes
Copy link
Owner

@giampaolo giampaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Alex.
I can’t merge from the phone so feel free to do it (and while you’re at it if you can update history/credits that would be great). If you can’t merge it I will have access to a laptop on monday (now i am traveling through china).

@wiggin15
Copy link
Collaborator Author

wiggin15 commented May 1, 2019

I'm not Alex ;) Safe travels.

@giampaolo
Copy link
Owner

Haha sorry. I confused you. :)

Arnon Yaari added 2 commits May 1, 2019 14:25
Fix giampaolo#1276: [AIX] use getargs to get process cmdline
e047be5
[AIX] Update resource links
d3e8e6a 
IBM removed the AIX 6.1 docs.
Use the 7.2 version instead.
@wiggin15
Copy link
Collaborator Author

wiggin15 commented May 1, 2019

Updated PR

  • free argbuf after use
  • Use PyUnicode_DecodeFSDefaultAndSize for pr_fname so we never over-read. Strip resulting \x00 characters that the "AndSize" variant might add.

@giampaolo giampaolo merged commit 7d8c23d into giampaolo:master May 6, 2019
nlevitt added a commit to nlevitt/psutil that referenced this pull request May 6, 2019
@nlevitt
Merge remote-tracking branch 'origin/master' into pslisten
68c12ae 
* origin/master:
  Fix giampaolo#1276: [AIX] use getargs to get process cmdline (giampaolo#1500) (patch by @wiggin15)
  Fix Process.ionice example using wrong keyword arg (giampaolo#1504)
  fix history syntax
  remove catching IOError; let the test fail and adjust it later
  Fix cpu freq (giampaolo#1496)
  pre release
  fix giampaolo#1493: [Linux] cpu_freq(): handle the case where /sys/devices/system/cpu/cpufreq/ exists but is empty.
  Revert "Fix cpu_freq (giampaolo#1493)" (giampaolo#1495)
  Fix cpu_freq (giampaolo#1493)
  Update cpu_freq to return 0 for max/min if not available (giampaolo#1487)
  give CREDITS to @agnewee for giampaolo#1491
  SunOS / net_if_addrs(): free() ifap struct on error (giampaolo#1491)
  fix giampaolo#1486: add wraps() decorator around wrap_exceptions
  refactor/move some utilities into _common.py
  update doc
  update HISTORY
  Implement getloadavg on Windows. Fixes giampaolo#604 and giampaolo#1484 (giampaolo#1485) (patch by Ammar Askar)
  give credits to @amanusk for giampaolo#1472
@wiggin15 wiggin15 deleted the issue-1276 branch May 7, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giampaolo giampaolo giampaolo approved these changes

Assignees
No one assigned
Labels
aix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't get whole command line on AIX platform
2 participants
@wiggin15 @giampaolo