#1044: cmdline() was incorrectly raising AD instead of ZombieProcess

psutil/arch/osx/process_info.c

@@ -141,13 +141,12 @@ psutil_get_cmdline(long pid) {
     mib[1] = KERN_PROCARGS2;
     mib[2] = (pid_t)pid;
     if (sysctl(mib, 3, procargs, &argmax, NULL, 0) < 0) {
-        if (EINVAL == errno) {
-            // EINVAL == access denied OR nonexistent PID
-            if (psutil_pid_exists(pid))
-                AccessDenied();
-            else
-                NoSuchProcess();
-        }
+        // In case of zombie process we'll get EINVAL. We translate it
+        // to NSP and _psosx.py will translate it to ZP.
+        if ((errno == EINVAL) && (psutil_pid_exists(pid)))
+            NoSuchProcess();
+        else
+            PyErr_SetFromErrno(PyExc_OSError);
         goto error;
     }
 

psutil/tests/test_osx.py

@@ -12,6 +12,7 @@
 
 import psutil
 from psutil import OSX
+from psutil.tests import create_zombie_proc
 from psutil.tests import get_test_subprocess
 from psutil.tests import MEMORY_TOLERANCE
 from psutil.tests import reap_children
@@ -99,6 +100,33 @@ def test_process_create_time(self):
             time.strftime("%Y", time.localtime(start_psutil)))
 
 
+@unittest.skipIf(not OSX, "OSX only")
+class TestZombieProcessAPIs(unittest.TestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        zpid = create_zombie_proc()
+        cls.p = psutil.Process(zpid)
+
+    @classmethod
+    def tearDownClass(cls):
+        reap_children(recursive=True)
+
+    def test_pidtask_info(self):
+        self.p.ppid()
+        self.p.uids()
+        self.p.gids()
+        self.p.terminal()
+        self.p.create_time()
+        self.p.status()
+
+    def test_exe(self):
+        self.assertRaises(psutil.ZombieProcess, self.p.exe)
+
+    def test_cmdline(self):
+        self.assertRaises(psutil.ZombieProcess, self.p.cmdline)
+
+
 @unittest.skipIf(not OSX, "OSX only")
 class TestSystemAPIs(unittest.TestCase):