Skip to content

Commit

Permalink
[ROCM] Turn on SLP vectorization (iree-org#18949)
Browse files Browse the repository at this point in the history
After doing review on the benchmarks we see that this is not causing any
model regression and we also did a benchmarking suite of attention
kernels for which in the past we thought this could cause a regression.
However, we didnt find any significant perf change. See
[here](https://docs.google.com/spreadsheets/d/102hYwdOGehmi_HhnLxHevwAVzMraKgKEjdTdUlJ4_TU/edit?usp=sharing)
As this is needed for correctness issue found in
iree-org#18798 we are turning on the SLP
vectorizer.

Signed-off-by: Nirvedh <nirvedh@gmail.com>
  • Loading branch information
nirvedhmeshram authored Oct 30, 2024
1 parent 554f31f commit 14f58e0
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions compiler/plugins/target/ROCM/ROCMTarget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ struct ROCMOptions {
int wavesPerEu = 0;
std::string enableROCMUkernels = "none";
bool legacySync = true;
bool slpVectorization = false;
bool slpVectorization = true;
bool globalISel = false;

/// List of LLVM opt pass pluggins to be loaded during GPU code
Expand Down Expand Up @@ -113,11 +113,9 @@ struct ROCMOptions {
"to be passed to the target backend compiler during HIP "
"executable serialization"),
cl::ZeroOrMore, cl::cat(category));
binder.opt<bool>(
"iree-hip-llvm-slp-vec", slpVectorization, cl::cat(category),
cl::desc(
"Enable slp vectorization in llvm opt. This can have an impact on "
"performance/numerics so its turned off by default currently."));
binder.opt<bool>("iree-hip-llvm-slp-vec", slpVectorization,
cl::cat(category),
cl::desc("Enable slp vectorization in llvm opt."));
binder.opt<bool>("iree-hip-llvm-global-isel", globalISel, cl::cat(category),
cl::desc("Enable global instruction selection in llvm."));
}
Expand Down

0 comments on commit 14f58e0

Please sign in to comment.