Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new ScalableFloatingPointChromosome capable of storing value be… #35

Closed

Conversation

sikora507
Copy link

…tween min/max for any given number of bits (more bits, greater precision)

…tween min/max for any given number of bits (more bits, greater precision)
@sikora507
Copy link
Author

I've added new chromosome capable of storing values between min and max value for any given number of bits.
For example
If we want to store values between -5 and 5 in 3 bits, we have 2^3 = 8 values available.
That way [0, 0, 0] will be minimum value (-5) and [1, 1, 1] maximum value(5).
[0, 0, 1] will become -3,75
[0, 1, 0] will become -2,5 and so on, up to [1, 1, 1] = 5

@giacomelli giacomelli self-requested a review October 3, 2018 23:49
@giacomelli giacomelli self-assigned this Oct 3, 2018
Copy link
Owner

@giacomelli giacomelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve code coverage

Please, add tests to validate the below ScalableFloatingPointChromosome's methods:

  • CreateNew
  • ToString

You can look into FloatingPointChromosomeTest for some test samples.

It would be nice too if you add a test to the GeneticAlgorithmTest, like Start_FloatingPoingChromosome_Evolved to assert how ScalableFloatingPointChromosome performs with the whole genetic algorithm and some genetic operators.

Solve issues

Please, solve the issues listed on https://sonarcloud.io/project/issues?branch=sikora507-ScalableFloatingPointChromosome&id=GeneticSharp&resolved=false

@giacomelli
Copy link
Owner

Closing it because of 6 months of inactive. If in any moment the points from #35 (review) was solved, please fell free to re-open it.

@giacomelli giacomelli closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants