Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default embedded font (JB Mono currently) should have italic style #2364

Closed
mitchellh opened this issue Oct 2, 2024 · 0 comments · Fixed by #2366
Closed

Default embedded font (JB Mono currently) should have italic style #2364

mitchellh opened this issue Oct 2, 2024 · 0 comments · Fixed by #2366

Comments

@mitchellh
Copy link
Contributor

Originally posted by @rockorager in #2363 (comment)

Ghostty's default embedded font doesn't have an italic variant so we produce a synthetic version (for italic and subsequently bold italic). Synthetic variants are never ideal, we should instead use a font file that has all the styles.

mitchellh added a commit that referenced this issue Oct 2, 2024
Fixes #2364

This adds the bold, italic, and bold italic variants of JB Mono so it is
built-in. This also fixes up the naming convention for the embedded font
files across tests and removes redundant embedded font files.
mitchellh added a commit that referenced this issue Oct 2, 2024
Fixes #2364

This adds the bold, italic, and bold italic variants of JB Mono so it is
built-in. This also fixes up the naming convention for the embedded font
files across tests and removes redundant embedded font files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant