Warning message on launch with Fish Shell #3676

SeanCassiere · 2024-12-28T08:01:45Z

SeanCassiere
Dec 28, 2024

Upon every cold launch of Ghostty (or even when opening a new tab using CMD + t), the application logs out this wall of text. This continues, even once I've set shell-integration = "fish" has been set in the Ghostty config file.

Have I missed a step somewhere here?

Last login: Sat Dec 28 20:57:08 on ttys003
set: Unknown option '--function'

/Applications/Ghostty.app/Contents/Resources/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish (line 17):
    set --function --path xdg_data_dirs "$XDG_DATA_DIRS"
    ^
in function 'ghostty_restore_xdg_data_dir'
        called on line 41 of file /Applications/Ghostty.app/Contents/Resources/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
from sourcing file /Applications/Ghostty.app/Contents/Resources/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
        called on line 253 of file /usr/local/share/fish/config.fish
from sourcing file /usr/local/share/fish/config.fish
        called during startup

(Type 'help set' for related documentation)
set: Unknown option '--function'

/Applications/Ghostty.app/Contents/Resources/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish (line 20):
    if set --function index (contains --index "$GHOSTTY_SHELL_INTEGRATION_XDG_DIR" $xdg_data_dirs)
       ^
in function 'ghostty_restore_xdg_data_dir'
        called on line 41 of file /Applications/Ghostty.app/Contents/Resources/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
from sourcing file /Applications/Ghostty.app/Contents/Resources/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
        called on line 253 of file /usr/local/share/fish/config.fish
from sourcing file /usr/local/share/fish/config.fish
        called during startup

(Type 'help set' for related documentation)

For reference, this is my fish config: https://github.com/SeanCassiere/dotfiles/blob/master/.config/fish/config.fish

Answered by SeanCassiere

Dec 28, 2024

@00-kat thanks for the kick in the butt I needed here.

Updating my version of Fish Shell to version 4.0b1 had those warnings go away.

View full answer

00-kat · 2024-12-28T08:12:37Z

00-kat
Dec 28, 2024

Fish version?

7 replies

SeanCassiere Dec 28, 2024
Author

fish, version 3.3.1

SeanCassiere Dec 28, 2024
Author

@00-kat thanks for the kick in the butt I needed here.

Updating my version of Fish Shell to version 4.0b1 had those warnings go away.

Answer selected by SeanCassiere

skyfaller Dec 28, 2024

This did not make these warnings go away for me. I had these warnings with fish 3.3.1 from apt on Pop OS. ~~I still have them now with fish version 4.0b1-62-g66b80041c compiled from the fish git repo.~~

Here's what I see on startup with Ghostty 1.0.1-main+bee21880:

set: Unknown option “--function”

~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish (line 17):
    set --function --path xdg_data_dirs "$XDG_DATA_DIRS"
    ^
in function 'ghostty_restore_xdg_data_dir'
        called on line 41 of file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
from sourcing file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
        called on line 253 of file /usr/share/fish/config.fish
from sourcing file /usr/share/fish/config.fish
        called during startup

(Type 'help set' for related documentation)
set: Unknown option “--function”

~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish (line 20):
    if set --function index (contains --index "$GHOSTTY_SHELL_INTEGRATION_XDG_DIR" $xdg_data_dirs)
       ^
in function 'ghostty_restore_xdg_data_dir'
        called on line 41 of file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
from sourcing file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
        called on line 253 of file /usr/share/fish/config.fish
from sourcing file /usr/share/fish/config.fish
        called during startup

(Type 'help set' for related documentation)
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
[11:57:12]
> fish --version
fish, version 4.0b1-62-g66b80041c
> ghostty --version
Ghostty 1.0.1-main+bee21880

Version
  - version: 1.0.1-main+bee21880
  - channel: tip
Build Config
  - Zig version: 0.13.0
  - build mode : builtin.OptimizeMode.ReleaseFast
  - app runtime: apprt.Runtime.gtk
  - font engine: font.main.Backend.fontconfig_freetype
  - renderer   : renderer.OpenGL
  - libxev     : main.Backend.io_uring
  - GTK version:
    build      : 4.6.9
    runtime    : 4.6.9
  - libadwaita : enabled
    build      : 1.1.7
    runtime    : 1.1.7
[12:01:00]

00-kat Dec 29, 2024

See if set --help shows documentation about a -f/--function flag; Fish 3.7.1 has it for me. You may have messed up somewhere when installing fish too, although I do doubt that.

skyfaller Dec 29, 2024

I do not see a -f / --function flag in set --help, or in the HTML version help set. If I'm running basically the same version of fish as @SeanCassiere, I'm not quite sure how this is possible. [EDIT: I was not running a recent version of fish.]

Just for funsies, I did a git pull and recompile on both fish and ghostty, and it's still not working right:

set: Unknown option “--function”

~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish (line 17):
    set --function --path xdg_data_dirs "$XDG_DATA_DIRS"
    ^
in function 'ghostty_restore_xdg_data_dir'
        called on line 41 of file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
from sourcing file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
        called on line 253 of file /usr/share/fish/config.fish
from sourcing file /usr/share/fish/config.fish
        called during startup

(Type 'help set' for related documentation)
set: Unknown option “--function”

~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish (line 20):
    if set --function index (contains --index "$GHOSTTY_SHELL_INTEGRATION_XDG_DIR" $xdg_data_dirs)
       ^
in function 'ghostty_restore_xdg_data_dir'
        called on line 41 of file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
from sourcing file ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish
        called on line 253 of file /usr/share/fish/config.fish
from sourcing file /usr/share/fish/config.fish
        called during startup

(Type 'help set' for related documentation)
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
[13:18:06]
> fish --version
fish, version 4.0b1-69-gb1064ac3a
[13:18:14]
> ghostty --version
Ghostty 1.0.1-main+6508fec9

Version
  - version: 1.0.1-main+6508fec9
  - channel: tip
Build Config
  - Zig version: 0.13.0
  - build mode : builtin.OptimizeMode.ReleaseFast
  - app runtime: apprt.Runtime.gtk
  - font engine: font.main.Backend.fontconfig_freetype
  - renderer   : renderer.OpenGL
  - libxev     : main.Backend.io_uring
  - GTK version:
    build      : 4.6.9
    runtime    : 4.6.9
  - libadwaita : enabled
    build      : 1.1.7
    runtime    : 1.1.7
  - libX11     : enabled

Lythenas Jan 3, 2025

I also ran into this issue today, since I'm still on Ubuntu 22.04 on one of my machines. The fish version there is 3.3.1 (and I think there is no "official" way to update it).

Can this be added to the documentation somewhere (or maybe even just checked when starting the shell)?

briprowe · 2025-01-05T23:36:54Z

briprowe
Jan 5, 2025

It looks like this issue is only a problem for older versions of fish (eg. v3.3.x). Based on the documentation of set, it looks like if we switch --function to --local this should work for both the older versions and the newer versions.

I've already done this locally. The error message is not printed, and things appear to be working fine. Should I make an issue first, or just submit a PR for review?

2 replies

skyfaller Jan 10, 2025

~~I still experience the problem on fish version 4.0.0-beta.1-gc1a43b896, so I don't think it's only an issue with older versions of fish.~~

But I did a find & replace for --function to --local in ~/.local/share/ghostty/shell-integration/fish/vendor_conf.d/ghostty-shell-integration.fish and that does seem to remove the error message when launching Ghostty.

skyfaller Jan 10, 2025

Welp I'm an idiot, I was launching Ghostty with the stable fish on my system, version 3.3.1.

> fish --version
fish, version 4.0.0-beta.1-gc1a43b896
> which fish
/home/nelson/.cargo/bin/fish
> $SHELL --version
fish, version 3.3.1
> echo $SHELL
/usr/bin/fish

So sorry for cluttering this discussion with my confusion.

Now I changed my Ghostty config to explicitly launch the latest fish:

command = ~/.cargo/bin/fish

And I can confirm it worked:

> sh -c 'ps -p $$ -o ppid=' | xargs -I'{}' readlink -f '/proc/{}/exe'
/home/nelson/.cargo/bin/fish

And I do not see the error messages after switching --function to --local, or if I put --function back the way it was.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warning message on launch with Fish Shell #3676

{{title}}

Replies: 2 comments 9 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

Warning message on launch with Fish Shell #3676

Replies: 2 comments · 9 replies

SeanCassiere Dec 28, 2024 Author

SeanCassiere Dec 28, 2024 Author

Replies: 2 comments 9 replies

SeanCassiere Dec 28, 2024
Author

SeanCassiere Dec 28, 2024
Author