Added Solaris 9 support #54
Conversation
|
@nalyanyam Could you please push the VAS portion to this branch as a separate commit and then find someone to test and report back here? |
|
@ghoneycutt |
| @@ -360,6 +360,31 @@ | |||
| } | |||
| 'Solaris': { | |||
| case $::kernelrelease { | |||
| '5.9': { | |||
| $default_pam_auth_lines = [ '# login service (explicit because of pam_dial_auth)', | |||
There was a problem hiding this comment.
we should not be putting in commented out lines that are not real comments in the file
There was a problem hiding this comment.
Thanks for the feedback.
These comments are only useful hints in pam.conf. Meant to make it easier for the person checking the file to understand why it is configured that way.
However, if that is the design strategy for the modules, then i will remove them and recommit. I will get these changes done on Monday.
There was a problem hiding this comment.
@nalyanyam: you can still add your comments via hiera ;)
|
Looking good. If you could remove those commented out lines noted above, I am more than happy to merge. Thanks for taking the time to add Solaris 9 support! |
|
@Phil-Friderici do these default values look good to you? I want to ensure they are Solaris defaults and not E defaults. |
|
@ghoneycutt: sorry, I don't know Solaris this well :( |
|
@ghoneycutt Actually the Solaris 9 pam defaults are not very different from Solaris 10 defaults apart from a couple of lines. |
|
@nalyanyam Thank you! I squashed and reworded your commit in PR #57 |
Added base support for Solaris 9