Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): Copy command from Context Menu should work with numbers #575

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

ghiscoding
Copy link
Owner

  • when trying the feature on a number, I found out that the numbers weren't copied because previous code was calling string methods on every call but we shouldn't on types number/null/undefined

- when trying the feature on a number, I found out that the numbers weren't copied because previous code was calling string methods on every call but we shouldn't on types number/null/undefined
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #575 (9d36491) into master (b4a889f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #575   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          230       230           
  Lines        15775     15776    +1     
  Branches      5089      5089           
=========================================
+ Hits         15775     15776    +1     
Impacted Files Coverage Δ
packages/common/src/extensions/slickContextMenu.ts 100.00% <100.00%> (ø)
...nilla-bundle/src/salesforce-vanilla-grid-bundle.ts
packages/salesforce-vanilla-bundle/src/index.ts
...s/vanilla-force-bundle/src/vanilla-force-bundle.ts 100.00% <0.00%> (ø)
packages/vanilla-force-bundle/src/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a889f...9d36491. Read the comment docs.

@ghiscoding ghiscoding merged commit 4803b5c into master Dec 10, 2021
@ghiscoding ghiscoding deleted the bugfix/context-menu-copy-number branch December 10, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant