Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selected does not update rows when 0 selected is shown even if rows are selected. #951

Closed
5 tasks done
kiranbangar5946 opened this issue Jul 6, 2022 · 4 comments · Fixed by #952
Closed
5 tasks done

Comments

@kiranbangar5946
Copy link

kiranbangar5946 commented Jul 6, 2022

Describe the bug

Update selected does not update rows when 0 selected is shown even if rows are selected.To reproduce this just run the solution directly go to composite editor and select rows and try to enter values and update.It wont work as it shows 0 selected.

Reproduction

Update selected does not update rows when 0 selected is shown even if rows are selected.To reproduce this just run the solution directly go to composite editor and select rows and try to enter values and update.It wont work as it shows 0 selected. Like '0 of Y selected'.

To make it work be on composite ediot page and refresh, Then select row and update selected would work. As it would reflect 'X of Y selected'.

Environment Info

https://ghiscoding.github.io/Angular-Slickgrid
Can visit this and check with above steps.

Validations

@ghiscoding
Copy link
Owner

I see the problem but please note that it only happens when routing from another page, basically it's all working correctly if you refresh the page

ghiscoding-SE pushed a commit that referenced this issue Jul 6, 2022
- fixes #951
- add dispose method to container service to start with a blank array whenever we route to another page, this is to avoid reusing already disposed services that might still be in the container service
ghiscoding added a commit that referenced this issue Jul 6, 2022
…election-count

fix(composite): selected row count always 0 on mass-selected, fix #951
@ghiscoding
Copy link
Owner

released a fix under the version v4.2.3
cheers and happy coding ⭐

@kiranbangar5946
Copy link
Author

Thanks a lot for such a quick fix and response !!

@ghiscoding
Copy link
Owner

welcome you can also ⭐ if you like the lib 😉
happy coding 👨🏻‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants