Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composite): selected row count always 0 on mass-selected, fix #951 #952

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

ghiscoding
Copy link
Owner

- fixes #951
- add dispose method to container service to start with a blank array whenever we route to another page, this is to avoid reusing already disposed services that might still be in the container service
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #952 (61fb22e) into master (495c6cc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #952   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          979       979           
  Branches       329       328    -1     
=========================================
  Hits           979       979           
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...es/angular-slickgrid/services/container.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fd6ee...61fb22e. Read the comment docs.

@ghiscoding ghiscoding merged commit 4904d7a into master Jul 6, 2022
@ghiscoding ghiscoding deleted the bugfix/composite-editor-row-selection-count branch July 6, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update selected does not update rows when 0 selected is shown even if rows are selected.
1 participant