feat(tree): add Tree Collapse Grid State/Preset #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ways to reapply Tree Collapse previous state whenever we want - add `initiallyCollapsed` flag to Tree Data Option to allow loading the grid as collapsed or not from the start (defaults to false) - add Grid Preset that can be used with Grid State - add `__hasChildren` flag to every dataset item that will always be included & also refactor Tree Formatters to use this new flag instead of querying next item - add `__collapsed` flag on all items which are parents, in other words don't add this flag to child item that have no children themselves - considerably improve speed of full expand/collapse performance (because the previous code was using `setItems` which was slowing down the toggling drastically)
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 162 162
Lines 11203 11315 +112
Branches 3938 3978 +40
==========================================
+ Hits 11203 11315 +112
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initiallyCollapsedflag to Tree Data Option to allow loading the grid as collapsed or not from the start (defaults to false)__hasChildrenflag to every dataset item that will always be included & also refactor Tree Formatters to use this new flag instead of querying next item__collapsedflag on all items which are parents, in other words don't add this flag to child item that have no children themselvessetItemswhich was slowing down the toggling drastically)TODOs