fix(filter): Grid Preset Filters should work with Tree Data View #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Jul 13, 2020
- the Tree Data must execute pre-filtering with Tree Data when having Grid Preset Filters
- the Tree Data must execute pre-filtering with Tree Data when having Grid Preset Filters
ghiscoding
commented
Jul 14, 2020
| grid.setColumns(gridColumns); | ||
| } | ||
| if (!this.customDataView) { | ||
| this.loadPresetsWhenDatasetInitialized(); |
There was a problem hiding this comment.
include all the other code below inside this if
ghiscoding
commented
Jul 14, 2020
| } | ||
| } | ||
|
|
||
| // bind external filter (backend) when available or default onFilter (dataView) | ||
| if (gridOptions.enableFiltering && !this.customDataView) { | ||
| this.filterService.init(grid); | ||
| this.loadPresetsWhenDatasetInitialized(); |
There was a problem hiding this comment.
remove this line since it will be shown below
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 148 148
Lines 9623 9634 +11
Branches 3360 3366 +6
=========================================
+ Hits 9623 9634 +11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.