Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding dataset hierarchical item shouldn't cause scroll flickering #1229

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 17, 2023

  • calling datasetHierarchical setter shouldn't cause scroll flickering, this was caused a call to the DataView setItems with an empty array which in terms always scroll back to top and that was meant to clear the dataset before recreating it, however this is certainly not needed since calling the datasetHierarchical setter will then trigger a new sort which will indirectly call DataView setItems anyway
  • it might also fix issue Tree scrolls and flickers on frequent update on tree data #1201, I'm not entirely sure since the user never mentioned which type of Tree Data was used (there's 2 types of Tree that exists)

- calling `datasetHierarchical` setter shouldn't cause scroll flickering, this was caused a call to the DataView `setItems` with an empty array which in terms always scroll back to top and that was meant to clear the dataset before recreating it, however this is certainly not needed since calling the `datasetHierarchical` setter will then trigger a new sort which will indirectly call DataView setItems anyway
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1229 (4c5864f) into master (bdaf568) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          919       916    -3     
  Branches       302       299    -3     
=========================================
- Hits           919       916    -3     
Files Changed Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit b13a590 into master Aug 17, 2023
@ghiscoding ghiscoding deleted the bugfix/dataset-hierarchical-flickering branch August 17, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant