Skip to content

Commit

Permalink
scripts-pnmtologo-fix-for-plain-pbm-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: do not initialise statics to 0 or NULL
torvalds#24: FILE: scripts/pnmtologo.c:77:
+static int is_plain_pbm = 0;

WARNING: line over 80 characters
torvalds#33: FILE: scripts/pnmtologo.c:108:
+	 * between the digits. This is Ok cause we know a PBM can only have a '1'

total: 1 errors, 1 warnings, 25 lines checked

./patches/scripts-pnmtologo-fix-for-plain-pbm.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Andreas Bießmann <andreas@biessmann.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and sfrothwell committed Jan 3, 2013
1 parent 0e2ec98 commit 842e279
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions scripts/pnmtologo.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,11 @@ static unsigned int get_number(FILE *fp)
val = 0;
while (isdigit(c)) {
val = 10*val+c-'0';
/* some PBM are 'broken'; GiMP for example exports a PBM without space
* between the digits. This is Ok cause we know a PBM can only have a '1'
* or a '0' for the digit. */
/*
* Some PBM are 'broken'; GiMP for example exports a PBM without space
* between the digits. This is OK because we know a PBM can only have a
* '1' or a '0' for the digit.
*/
if (is_plain_pbm)
break;
c = fgetc(fp);
Expand Down

0 comments on commit 842e279

Please sign in to comment.