BUG: Adjust MKS317's limits for the ValidLo state #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ghalym,
This should address the issues described in pcdshub#36.
Additionally the FB used an odd mix of constants which were then skipped in favor of hard-coded constants.
I've set the limit to .15 volts which is probably lower than necessary but I think it should be alright as that voltage range shouldn't have any other meanings.
I also noticed that there used to be a strange deadzone between .6V and .22V. I've left it in but I'm not entirely sure if that's the right decision.
@slacAWallace