Add MW_FEATURE_BITMAPS to enable GrBitmap support #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofl0r
reviewed
Mar 12, 2025
| @@ -1236,7 +1237,9 @@ GdDrawImageByPoint(PSD psd, MWCOORD x, MWCOORD y, PMWIMAGEHDR pimage) | |||
|
|
|||
| GdFixCursor(psd); | |||
| } | |||
| #endif /* MW_FEATURE_IMAGES*/ | |||
There was a problem hiding this comment.
the corresponding #if was commented out, so either this endif is completely dangling or at least the comment no longer accurate.
There was a problem hiding this comment.
Thanks for looking at this. I think the diff combined with my change makes this looks odd - as there used to be an embedded #if MW_FEATURE_IMAGES on line 851 which I changed to #if MW_FEATURE_ALPHA and commented out.
So, this #endif and comment are actually correct and match the corresponding #if MW_FEATURE_IMAGES on line 533.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by @tyama501 for Japanese text viewer discussed in ghaerr/elks#1387 (comment).