Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Rust Toolchain #160

Closed
wants to merge 1 commit into from
Closed

Updating Rust Toolchain #160

wants to merge 1 commit into from

Conversation

xcthulhu
Copy link
Contributor

Updating rust-toolchain to use nightly-2023-08-19

@obsessed-cake
Copy link
Contributor

LGTM

@akorchyn
Copy link
Contributor

Does a node work with new toolchain ?

@akorchyn
Copy link
Contributor

Copy link
Contributor

@akorchyn akorchyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should test it first

@obsessed-cake
Copy link
Contributor

obsessed-cake commented Aug 20, 2023

$ git log -n 1
commit 54b64a0d5ec234f726c23b85ef41cf99f6876880 (HEAD -> bump-rust-toolchain, origin/bump-rust-toolchain)
Author: Matthew Doty <matt@w-d.org>
Date:   Sun Aug 20 12:42:16 2023 -0400

    Updating rust toolchain

$ cargo run -- --dev
     Finished dev [unoptimized + debuginfo] target(s) in 0.91s
     Running `target/debug/ggxchain-node --dev`
2023-08-20 20:29:40 GGX chain node    
2023-08-20 20:29:40 ✌️  version 0.1.0-54b64a0d5ec    
2023-08-20 20:29:40 ❤️  by GGXChain <admin@ggxchain.io>, 2021-2023    
2023-08-20 20:29:40 📋 Chain specification: Development    
2023-08-20 20:29:40 🏷  Node name: neat-bike-9362    
2023-08-20 20:29:40 👤 Role: AUTHORITY    
2023-08-20 20:29:40 💾 Database: RocksDb at /tmp/substratewc8gIL/chains/dev/db/full    
2023-08-20 20:29:40 ⛓  Native runtime: ggxchain-node-7 (ggxchain-node-1.tx1.au1)    
2023-08-20 20:29:41 [0] 💸 generated 5 npos voters, 1 from validators and 4 nominators    
2023-08-20 20:29:41 [0] 💸 generated 1 npos targets    
Error: Service(Client(VersionInvalid("cannot deserialize module: UnknownOpcode(192)")))
2023-08-20 20:29:42 Cannot create a runtime error=Other("cannot deserialize module: UnknownOpcode(192)")

@akorchyn
Copy link
Contributor

As the above issue is confirmed, we can't migrate until the proper fix is created for the substrate. So, let's move to draft it and keep it for latter.

@xcthulhu xcthulhu marked this pull request as draft August 21, 2023 12:52
@xcthulhu
Copy link
Contributor Author

Looks like we need to update substrate to incorporate this fix: paritytech/substrate#13804

@akorchyn
Copy link
Contributor

it's not easy task as we have other substrate deps. Also, we can live with older version for a while, it's not crucial.

@uchu
Copy link
Contributor

uchu commented Aug 26, 2023

I think we need to work on these updates to be able to upgrade rust toolchain

@akorchyn
Copy link
Contributor

Absorbed by #187

@akorchyn akorchyn closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants