Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use lifecycle for arguments deprecation in ggpairs #494

Merged
merged 5 commits into from
Apr 12, 2024
Merged

chore: Use lifecycle for arguments deprecation in ggpairs #494

merged 5 commits into from
Apr 12, 2024

Conversation

92amartins
Copy link
Collaborator

@92amartins 92amartins commented Mar 28, 2024 •
edited
Loading

This aims to partially fix #365.

It only deprecates arguments in the ggpairs.

If desired I can follow up with deprecation warnings for the other files that have functions deprecated functions/arguments:

  • deprecated.R
  • gg-plots.R
  • gg_matrix_gtable.R
  • ggnet.R

schloerke
schloerke requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept new snaps or remove the new gglegend snaps

R/ggpairs.R Show resolved Hide resolved
R/ggpairs.R Show resolved Hide resolved
R/ggpairs.R Outdated Show resolved Hide resolved
@schloerke
Copy link
Member

If desired I can follow up with deprecation warnings for the other files that have functions deprecated functions/arguments:

  • deprecated.R
  • gg-plots.R
  • gg_matrix_gtable.R
  • ggnet.R

Yes, please! Thank you

@92amartins 92amartins force-pushed the deprecate-ggpairs-args branch from 4929ae2 to 759f5b6 Compare April 11, 2024 15:10
@92amartins 92amartins force-pushed the deprecate-ggpairs-args branch from 912ddb8 to 1fc3d59 Compare April 11, 2024 23:26
@92amartins
Copy link
Collaborator Author

If desired I can follow up with deprecation warnings for the other files that have functions deprecated functions/arguments:

  • deprecated.R
  • gg-plots.R
  • gg_matrix_gtable.R
  • ggnet.R

Yes, please! Thank you

I'm thinking about breaking down these changes in maybe 2 or 3 PR's, what do you think?

@92amartins 92amartins requested a review from schloerke April 11, 2024 23:39
schloerke
schloerke reviewed Apr 12, 2024
View reviewed changes
R/ggpairs.R Outdated Show resolved Hide resolved
R/ggpairs.R Outdated Show resolved Hide resolved
R/ggpairs.R Outdated Show resolved Hide resolved
R/ggpairs.R Outdated Show resolved Hide resolved
R/ggpairs.R Outdated Show resolved Hide resolved
@schloerke
Copy link
Member

I'm thinking about breaking down these changes in maybe 2 or 3 PR's, what do you think?

Let's get this PR merged in so that your GHA runs will happen automatically. If it's all in the same idea... let's do it in a single followup PR.

schloerke
schloerke reviewed Apr 12, 2024
View reviewed changes
R/ggpairs.R Outdated Show resolved Hide resolved
@schloerke
Copy link
Member

Merging

The two ubuntu errors are due to install failures from a dep package for {emmeans} unrelated to this PR. (Happens on master branch.)

@schloerke schloerke changed the title Use lifecycle for arguments deprecation in ggpairs chore: Use lifecycle for arguments deprecation in ggpairs Apr 12, 2024
@schloerke schloerke merged commit 1f58feb into ggobi:master Apr 12, 2024
7 of 9 checks passed
@92amartins 92amartins mentioned this pull request Apr 22, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use lifecycle to issue deprecation warnings
2 participants
@92amartins @schloerke