Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when running train with CUDA enabled #1952

Closed
wants to merge 1 commit into from

Conversation

howard0su
Copy link
Collaborator

Although CUDA GPU is not used during training, CUDA will crash due to the assumption on tensor->src0 is not NULL. The assumption is wrong when op is GGML_OP_NONE, which is used for backward grad computing.

@howard0su
Copy link
Collaborator Author

Another approach to fix #1869

@howard0su howard0su requested review from ggerganov and JohannesGaessler and removed request for ggerganov June 20, 2023 16:01
@howard0su
Copy link
Collaborator Author

Replace by #1907

@howard0su howard0su closed this Jun 24, 2023
@howard0su howard0su deleted the fix_train branch June 28, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant