Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP: fix flash_attn_stream_k_fixup warning #11604

Merged

Conversation

JohannesGaessler
Copy link
Collaborator

Fixes #11602 .

Simply suppresses the warning. I'll investigate whether there is an actual issue where the CUDA compiler cannot unroll loops (but without a warning).

@github-actions github-actions bot added Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Feb 2, 2025
Copy link
Collaborator

@IMbackK IMbackK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JohannesGaessler JohannesGaessler merged commit 6eecde3 into ggml-org:master Feb 2, 2025
46 checks passed
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile bug: new mma fattn uses constructs that can not be unrolled by llvm casueing a tonne of warnings
2 participants