Treat hf.co/ prefix the same as hf:// #11350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11eb2be to
2d5382e
Compare
|
@ngxson wanna review this one, should be a quick one I think. Will complete the hf.co protocol thing in some other PR. This just means we tread "hf.co/, "hf://", "huggingface://" the same. |
ngxson
approved these changes
Jan 23, 2025
examples/run/run.cpp
Outdated
| @@ -634,20 +634,20 @@ class LlamaData { | |||
| return path.substr(pos + 1); | |||
| } | |||
|
|
|||
| int remove_proto(std::string & model_) { | |||
| const std::string::size_type pos = model_.find("://"); | |||
| int rm_substring(std::string & model_, const std::string & substring) { | |||
There was a problem hiding this comment.
the function name is a quite misleading because I thought that it's replace(substr, "") at first. Probably rm_until_substring make it more clear
There was a problem hiding this comment.
Renamed, please re-review @ngxson
ollama uses hf.co/ to specify huggingface prefix, like RamaLama uses hf:// Treat them similarly. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
ngxson
approved these changes
Jan 23, 2025
anagri
pushed a commit
to BodhiSearch/llama.cpp
that referenced
this pull request
Jan 26, 2025
ollama uses hf.co/ to specify huggingface prefix, like RamaLama uses hf:// Treat them similarly. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
ollama uses hf.co/ to specify huggingface prefix, like RamaLama uses hf:// Treat them similarly. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
ollama uses hf.co/ to specify huggingface prefix, like RamaLama uses hf:// Treat them similarly. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
ollama uses hf.co/ to specify huggingface prefix, like RamaLama uses hf:// Treat them similarly. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ollama uses hf.co/ to specify huggingface prefix, like RamaLama uses hf://
Treat them similarly.