-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server : (web UI) Add back sampler settings #10239
Conversation
It's good to add more sampler options, but IMO this UI should focus strictly on usability. As it is, a list of options without any explanation is not much better than the "custom JSON config" field. |
It's already better by not having to print or copy-paste "xtc_probability" manually XD
If I were to add "tooltips" for samplers, should I also consider mobile use (i.e. vertical orientation/aspect ratios)? |
Thank you for fixing the name, forgot to change it. The only thing that bugs me here is the scrollbar. It appears that there's no universal way to change it (and it's not a built-in element, like in ImgUi). Is it possible to shift settings content in order to always reserve a space for the scrollbar? |
I pushed some changes:
Can you test it once more time to confirm that it's still working correctly @MaggotHATE ? Then I think it's good to merge. Thank you. |
@ngxson looks like everything works correctly, thank you! Would tooltips work on mobile though? So far this UI is compatible with touch, even though it's not the main focus for now. It was the only reason I went with modals. |
I haven't tested, but because the tooltip is implemented using tailwindcss make it quite easy to make responsive UI though, so normally I don't have to worry too much about that. We can fix responsiveness in the future if users really need it. |
Side note, I'm not very confident that the settings are being categorized in a correct manner (i.e. DRY should be re-grouped to its own section?) Not a big issue though, suggestion are welcomed for that part. |
Previous versions of server UI didn't have any such grouping, only "More options/Further options", I think it's good for now because it serves the purpose and looks uniform with the rest of UI. Given the limited space (it's probably not a good idea to have a looooong settings menu from the beginning) we might have to introduce smaller UI elements with more densely packed information in them (like more granular grouping). |
* Add back samplers to server * Added tooltips with basic information * Fixed stretching of input fields. * use component for settings input, move help msg to tooltips --------- Co-authored-by: Xuan Son Nguyen <son@huggingface.co>
* Add back samplers to server * Added tooltips with basic information * Fixed stretching of input fields. * use component for settings input, move help msg to tooltips --------- Co-authored-by: Xuan Son Nguyen <son@huggingface.co>
This PR adds samplers and penalties back into new server UI - I'm taking small iterative steps with this since I'm not familiar with
vue
yet. I've divided them into two "sections" for better distinction.