-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix whisper.objc Xcode project #2736
Conversation
…nd add new files that were missing
Thanks! Let's re-enable the whisper.cpp/.github/workflows/build.yml Lines 679 to 682 in b82d305
|
Beautiful, thank you for fixing this so quickly! Just FYI the SwiftUI example was also broken when I tried it, not sure if it's for the same reason though. I didn't investigate very deeply. |
The CI encounters a code signing error: I think we need to add |
Alright, I disabled code signing and got the build working locally. Hopefully it works in CI! @ggerganov I also fixed the SwiftUI example. Would you prefer I open a separate PR for that or just add it here? It's just updating Package.swift to reflect the recent changes. |
Great! Let's make the SwiftUI changes in another PR. I will merge this one as soon as the CI is green. |
After the recent |
@iamcgn Thanks for the help! |
This PR updates the whisper.objc Xcode project so that it compiles. The project referenced 2 files that had been renamed and was missing references to
ggml-cpu-traits.c
andggml-cpu-traits.h
. I also had to explicitly add the-x c++
flag to convince Xcode to compileggml-cpu-aarch64.cpp
as C++ rather than C. I tested these changes in Xcode 16.2.