fix ffmpeg v5 build #2543
Merged
fix ffmpeg v5 build #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove call to 'av_register_all()' which does not exist in ffmpeg v5 anymore.
ggerganov
approved these changes
Nov 13, 2024
adutilleul
pushed a commit
to adutilleul/whisper.cpp
that referenced
this pull request
Nov 19, 2024
remove call to 'av_register_all()' which does not exist in ffmpeg v5 anymore.
| @@ -204,8 +204,6 @@ static int decode_audio(struct audio_buffer *audio_buf, s16 **data, int *size) | |||
| const size_t errbuffsize = 1024; | |||
| char errbuff[errbuffsize]; | |||
|
|
|||
| av_register_all(); // from avformat. Still a must-have call for ffmpeg v3! (can be skipped for later versions) | |||
There was a problem hiding this comment.
naive and bad modif: breaks the ffmpeg v3 build.
Proper modif should have been:
#ifdef FFMPEG_VERSION < 5
av_register_all();
#endif
There was a problem hiding this comment.
If you want this to happen just do a PR with:
#ifdef FFMPEG_VERSION < 4
av_register_all();
#endif
In anyway this is an example for the current state and meant to be simple.
I find the tone quite harsh and not inviting for help.
The caveat for ffmpeg 3.0 was clearly mentioned in the description though.
The call is deprecated since ffmpeg 4.0 in 2018.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove call to
av_register_all()from the transcode example,which does not exist in ffmpeg v5 anymore.
This will break ffmpeg v3, if this needs to be supported still, we need a different approach.