Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download coreml script with zipfile #1381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yanyaoer
Copy link

Fix download url with zipfile and extra

@bobqianic
Copy link
Collaborator

I think these two parts also need some changes.

image image

@yanyaoer yanyaoer force-pushed the fix_download_coreml branch from dc4b26d to b7a80af Compare October 23, 2023 02:08
@pkreissel
Copy link

I tried your commit locally. It did not work.
First it provided a zip-file, maybe the script could unpack that automatically?
The corelmc required a file called "ggml-medium.mlmodel" so I renamed the unpacked file to that.
Then corelmc command then complained that there was no Manifest.json in the model.
I tried renaming the metadata.json to manifest.json but it did not work.

I hope this is helpful in improving the script, also I would be happy if someone could help me with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants