Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift Package Manager #1370

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

sindresorhus
Copy link
Contributor

Not ready. Depends on syncing with llama.cpp to get latest ggml-metal (also ggml-backend and k_quants).

@sindresorhus sindresorhus changed the title Add support for Swift Add support for Swift Package Manager Oct 16, 2023
@ggerganov
Copy link
Owner

Bringing all llama.cpp stuff with #1422 - after that, will work on improving the build across platforms, new features and some performance improvements. Hopefully will be ready in the following week.

@sindresorhus sindresorhus marked this pull request as ready for review November 7, 2023 14:50
@sindresorhus
Copy link
Contributor Author

@ggerganov I have synced it from llama.cpp again. It now builds successfully in Xcode for me. I added it as a local dependency to my app.


I'm also seeing https://github.com/ggerganov/whisper.spm/blob/9752de41007fc54df5d6f98945929a54bc628a58/Package.swift#L23-L26, but I don't think that should stop it from being included here as it does build in Xcode, which is the main use-case. We could maybe document the caveat for now?

@ggerganov
Copy link
Owner

Since it works on your end, I think we can assume I was doing something wrong, so we should proceed.
Just to make sure I understand: merging this will technically obsolete the whisper.spm and people can simply use the whisper.cpp repo in their Swift projects, correct?

@sindresorhus
Copy link
Contributor Author

Just to make sure I understand: merging this will technically obsolete the whisper.spm and people can simply use the whisper.cpp repo in their Swift projects, correct?

Correct

@sindresorhus
Copy link
Contributor Author

I have updated the SwiftUI example app to use the package: bacf34d

@ggerganov ggerganov merged commit d03c60d into ggerganov:master Nov 7, 2023
34 of 35 checks passed
@sindresorhus sindresorhus deleted the spm branch November 8, 2023 08:40
felrock pushed a commit to felrock/whisper.cpp that referenced this pull request Nov 18, 2023
* Add support for Swift

* Make it build in Xcode

* Use the SPM package in the SwiftUI example app
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
* Add support for Swift

* Make it build in Xcode

* Use the SPM package in the SwiftUI example app
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
* Add support for Swift

* Make it build in Xcode

* Use the SPM package in the SwiftUI example app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants