Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CANN]: Fix ggml_backend_cann_buffer_get_tensor #8871

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[CANN]: Fix ggml_backend_cann_buffer_get_tensor #8871

merged 2 commits into from
Aug 6, 2024

Conversation

MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented Aug 5, 2024 •
edited
Loading

  1. Fix data ptr offset
  2. Enable the acquisition of incomplete tensors
  3. The precision problem of operator ARGSORT is fixed by this PR
    image

@MengqingCao
cann: fix ggml_backend_cann_buffer_get_tensor
2340ff5 
 1. fix data ptr offset
 2. enable the acquisition of incomplete tensors
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Aug 5, 2024
@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix bugfix fixes an issue or bug labels Aug 5, 2024
@hipudding hipudding added the Ascend NPU issues specific to Ascend NPUs label Aug 6, 2024
@hipudding hipudding merged commit c21a896 into ggerganov:master Aug 6, 2024
53 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Aug 7, 2024
@MengqingCao @arthw
[CANN]: Fix ggml_backend_cann_buffer_get_tensor (ggerganov#8871)
03571c9 
* cann: fix ggml_backend_cann_buffer_get_tensor

 1. fix data ptr offset
 2. enable the acquisition of incomplete tensors

* fix backend cann set_tensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipudding hipudding hipudding approved these changes

Assignees
No one assigned
Labels
Ascend NPU issues specific to Ascend NPUs bugfix fixes an issue or bug ggml changes relating to the ggml tensor library for machine learning Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MengqingCao @hipudding @mofosyne