cmake: fix paths for vulkan shaders compilation on Windows

[stduhpf]

Fixes #8562

I hope it's not breaking it for others.

• I have read the contributing guidelines
• Self-reported review complexity:
  • Low
  • Medium
  • High

[mstephenson6]

Just got successful Vulkan builds with MSBuild/cl and ninja/clang on Windows 11 x64 with this PR, thank you!

[0cc4m]

Looks good to me. No issues on Linux. I can't test Windows, but other commenters confirmed that it works there. Thank you.

[MaggotHATE]

Compilation fails on w64Devkit with this update:

error: 'replace' is not a member of 'std'
  487 |             std::replace(path.begin(), path.end(), '/', '\\' );

[Donwulff]

Seconding this, not fixed, from my limited perspective into the code it's bit perplexing because the build seems to be fixed at -std=c++11 while std::replace is c++20 onwards, how is this supposed to work anywhere?

[0cc4m]

Seconding this, not fixed, from my limited perspective into the code it's bit perplexing because the build seems to be fixed at -std=c++11 while std::replace is c++20 onwards, how is this supposed to work anywhere?

I agree the way it is shown by default in the documentation makes it look like std::replace is available since C++17 or C++20, but if you set the C++ revision at the top of the page you can see that std::replace is available since C++98. That's not the issue.

Maybe the problem for w64Devkit is just that #include <algorithm> is missing in the #ifdef _WIN32 include part at the top? Can you try that?

[MaggotHATE]

#include

Yes, it seems to be the case #8880
Although I've missed your comment and didn't put it under #ifdef _WIN32 - is it critical?

[0cc4m]

#include

Yes, it seems to be the case #8880 Although I've missed your comment and didn't put it under #ifdef _WIN32 - is it critical?

Not critical, but the algorithm part is in a Windows-only section.