Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Fix filename for convert-hf-to-gguf.py in tools.sh #8441

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Docker: Fix filename for convert-hf-to-gguf.py in tools.sh #8441

merged 1 commit into from
Jul 12, 2024

Conversation

kriation
Copy link
Contributor

Commit b0a4699 changed the name of this script from convert-hf-to-gguf.py to convert_hf_to_gguf.py breaking how convert is called from within a Docker container.

@kriation
Fix filename for convert-hf-to-gguf.py
58ccca0 
Commit b0a4699 changed the name of this script from convert-hf-to-gguf.py to
convert_hf_to_gguf.py breaking how convert is called from within a Docker
container.
@github-actions github-actions bot added the devops improvements to build systems and github actions label Jul 11, 2024
@oldgithubman
Copy link

Commit b0a4699 changed the name of this script from convert-hf-to-gguf.py to convert_hf_to_gguf.py breaking how convert is called from within a Docker container.

How do I get write access? I think I'm qualified to approve this one =;-)

@ggerganov ggerganov merged commit 8a4441e into ggerganov:master Jul 12, 2024
1 check passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
@kriation
docker : fix filename for convert-hf-to-gguf.py in tools.sh (ggergano…
20ab533 
…v#8441)

Commit b0a4699 changed the name of this script from convert-hf-to-gguf.py to
convert_hf_to_gguf.py breaking how convert is called from within a Docker
container.
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
@kriation
docker : fix filename for convert-hf-to-gguf.py in tools.sh (ggergano…
3ebd51f 
…v#8441)

Commit b0a4699 changed the name of this script from convert-hf-to-gguf.py to
convert_hf_to_gguf.py breaking how convert is called from within a Docker
container.
@kriation kriation deleted the bug/docker-entrypoint-convert branch July 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

@oldgithubman oldgithubman oldgithubman approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kriation @oldgithubman @ggerganov