Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggml : add NVPL BLAS support (#8329) #8425

Merged
merged 2 commits into from
Jul 11, 2024
Merged

ggml : add NVPL BLAS support (#8329) #8425

merged 2 commits into from
Jul 11, 2024

Conversation

nicholaiTukanov
Copy link
Contributor

@nicholaiTukanov nicholaiTukanov commented Jul 10, 2024 •
edited
Loading

Changelist:

  • Adds GGML_NVPL as a build option in the makefile
  • Adds a code path in ggml-blas.cpp to handle including NVPL BLAS and setting NVPL BLAS threads via NVPL_ENABLE_CBLAS

This solves #8329

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Jul 10, 2024
slaren
slaren reviewed Jul 10, 2024
View reviewed changes
ggml/src/ggml-blas.cpp Outdated Show resolved Hide resolved
@slaren slaren merged commit 3686456 into ggerganov:master Jul 11, 2024
52 checks passed
@nicholaiTukanov nicholaiTukanov mentioned this pull request Jul 11, 2024
Closed
4 tasks
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 12, 2024
@nicholaiTukanov @Nexesenex
ggml : add NVPL BLAS support (ggerganov#8329) (ggerganov#8425)
313864d 
* ggml : add NVPL BLAS support

* ggml : replace `<BLASLIB>_ENABLE_CBLAS` with `GGML_BLAS_USE_<BLASLIB>`

---------

Co-authored-by: ntukanov <ntukanov@nvidia.com>
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 12, 2024
@nicholaiTukanov @Nexesenex
ggml : add NVPL BLAS support (ggerganov#8329) (ggerganov#8425)
62f4c22 
* ggml : add NVPL BLAS support

* ggml : replace `<BLASLIB>_ENABLE_CBLAS` with `GGML_BLAS_USE_<BLASLIB>`

---------

Co-authored-by: ntukanov <ntukanov@nvidia.com>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
@nicholaiTukanov
ggml : add NVPL BLAS support (ggerganov#8329) (ggerganov#8425)
b352f76 
* ggml : add NVPL BLAS support

* ggml : replace `<BLASLIB>_ENABLE_CBLAS` with `GGML_BLAS_USE_<BLASLIB>`

---------

Co-authored-by: ntukanov <ntukanov@nvidia.com>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
@nicholaiTukanov
ggml : add NVPL BLAS support (ggerganov#8329) (ggerganov#8425)
b4caa00 
* ggml : add NVPL BLAS support

* ggml : replace `<BLASLIB>_ENABLE_CBLAS` with `GGML_BLAS_USE_<BLASLIB>`

---------

Co-authored-by: ntukanov <ntukanov@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaiTukanov @slaren