sycl-exp : Temporarily revert RPC offload (#7640) #7981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bde7cd3.
AidanBeltonS
approved these changes
Jun 18, 2024
Alcpz
pushed a commit
to Alcpz/llama.cpp
that referenced
this pull request
Jun 20, 2024
…ov#7640)" (ggerganov#7981) This reverts commit bde7cd3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts PR #7640 on our experimental branch as the SYCL backend hasn't been adapted for this change. Eventually this will need to be properly addressed, but for now we revert to check our upcoming performance improvements.
There are a lot of code changes here, but it's a single revert commit, so I am marking this Low.