-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per token attributes #7685
Merged
Merged
Per token attributes #7685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
Everything test related
python
python script changes
labels
Jun 1, 2024
jaime-m-p
force-pushed
the
per-token-attribs
branch
from
June 1, 2024 23:47
cc55198
to
01c9229
Compare
mofosyne
added
the
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
label
Jun 3, 2024
ggerganov
approved these changes
Jun 3, 2024
CISC
reviewed
Jun 4, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
python
python script changes
Review Complexity : Medium
Generally require more time to grok but manageable by beginner to medium expertise level
testing
Everything test related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token attributes may differ from model to model.
This is affecting the special token splitting.
This PR implements a general way to manage per token attributes.
For now only attributes
lstrip
andrstrip
are implemented, neccesary for models phi-3 and jina-v2-es/de.phi-3/tokenizer_config.json
:dolphin-2.8-mistral-7b-v02/tokenizer_config.json
:This information is currently not stored in the GGUF (WIP #7379).
I'm using harcoded attributes and tokenizer/model names until we have a better option.