Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NotImplementedError in convert-hf-to-gguf #7660

Merged
merged 1 commit into from
May 31, 2024

Conversation

Galunid
Copy link
Collaborator

@Galunid Galunid commented May 31, 2024

Error message was not very user friendly since it was a whole stack trace. We raise this error when model is not yet supported, so stack trace can be replaced with nicer message instead of wall of text.

@github-actions github-actions bot added the python python script changes label May 31, 2024
@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix merge ready indicates that this may be ready to merge soon and is just holding out in case of objections labels May 31, 2024
@Galunid Galunid merged commit 0515ad9 into ggerganov:master May 31, 2024
20 checks passed
@Galunid Galunid deleted the clear-message branch May 31, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge ready indicates that this may be ready to merge soon and is just holding out in case of objections python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants