-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llama_supports_rpc()
function
#7647
llama_supports_rpc()
function
#7647
Conversation
After #7640 we should consider including the RPC backend in all the llama.cpp builds by default. Then this function wouldn't be necessary. |
We already have |
Ah I hadn't noticed that GGML function. If that's equivalent to what I've added here that should be fine. LLamaSharp (and I would guess other wrappers) doesn't usually expose GGML functions, but if this is only temporary anyway then it's fine. |
@martindevans just following up on this PR as it was marked merge ready. Is the CI issue due to your code change, if not then resync against last known master with working ci commit. |
Well I managed to make a mess of that merge (fixed now I think)! 😨 Is there still interest in merging this? The majority of the feedback seemed to be that this was going to be temporary, and wasn't even really needed since there's already an equivalent. |
f87e6ac
to
9b15621
Compare
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
9b15621
to
a79da45
Compare
I don't think we need this function unless you have some good reasons for not using the existing |
Just checking - it it exported in the C-API like all of the llama methods? if so, I think it'll work just fine for LLamaSharp to use that and I'll close this PR :) |
yes, it is exported: $ nm -D libllama.so | grep has_rpc
000000000018c130 T ggml_cpu_has_rpc
|
Thanks for confirming, in that case I'll close this PR 👍 |
Added
llama_supports_rpc
function to test for RPC support at runtime. This is useful for libraries such as LLamaSharp which need to check what the binaries were compiled with before trying to use certain features.