Extend README with brew installation instruction [no ci] #7616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dont forget to add [no ci] to documentation only changes in your commit title |
mofosyne
approved these changes
May 29, 2024
There was a problem hiding this comment.
Identified that llama.cpp is in https://formulae.brew.sh/formula/llama.cpp and that there is already a formula for it in https://github.com/Homebrew/homebrew-core/blob/master/Formula/l/llama.cpp.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llama.cppis now available in Homebrew (see here and here). I think it would be helpful to extend the README to raise awareness of that installation possibility. This PR is adding that information to the README file.I am not sure if this information should be positioned somewhere else in the README, maybe right before the Prepare and Quantize chapter or even before the Get the Code chapter, I am happy to receive feedback on that as well.