Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server : tuning tests #7388

Merged
merged 4 commits into from
May 20, 2024
Merged

server : tuning tests #7388

merged 4 commits into from
May 20, 2024

Conversation

ggerganov
Copy link
Owner

@ggerganov ggerganov commented May 19, 2024 •
edited
Loading

  • Fix incorrect passing of the temperature as the string "0.8f"
  • Increase timeout to make the thread sanitizer workflow pass
  • Pass temperature explicitly where it matters

@github-actions github-actions bot added examples python python script changes server labels May 19, 2024
JohannesGaessler
JohannesGaessler approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous comment, I had mixed up old and new.

@mofosyne mofosyne added refactoring Refactoring Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 20, 2024
@ggerganov ggerganov marked this pull request as ready for review May 20, 2024 07:16
@ggerganov ggerganov merged commit 1cc0155 into master May 20, 2024
19 checks passed
@ggerganov ggerganov deleted the gg/server-tests branch May 20, 2024 07:16
JohannesGaessler
JohannesGaessler reviewed May 20, 2024
View reviewed changes
examples/server/tests/features/results.feature
@@ -13,6 +13,7 @@ Feature: Results

Scenario Outline: consistent results with same seed
Given <n_slots> slots
And 0.0 temperature
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set to temperature 1, not temperature 0. With temperature 0 you get greedy decoding in which case the seed is irrelevant. So this test can no longer detect issues with e.g. the RNG state being shared between slots.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, will push a fix now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesGaessler JohannesGaessler JohannesGaessler approved these changes

Assignees
No one assigned
Labels
examples python python script changes refactoring Refactoring Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggerganov @JohannesGaessler @mofosyne