-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI maintenance: Update checkout, setup-python and upload-artifact to latest versions #6456
Conversation
Thanks, have you tested on your fork that it works ? If yes please send links |
Right, missed that one, triggered it here: https://github.com/EwoutH/llama.cpp/actions/runs/8539946210 |
I am prudent because the way the repo is cloned has an impact on the build-info.o object. |
I understand. All the runs have passed successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having looking at this, please wait for @ggerganov approval
Thanks for merging! Would a Dependabot configuration be useful, which opens such PRs automatically in the future? |
@ggerganov @EwoutH I guess it blocks master as now artifact name are duplicated: I suggest to revert and wait for a solution |
Give me a sec, looking into it: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#migration If I understand correctly it just requires naming artifacts differently. |
Basically there are two options:
What’s preferred? |
Let's keep it simple, one artifact per job run |
I don't have a preference and I'm not sure what is useful for most people. We can do the one artifact per job as suggested and if we see it is not optimal for some reason we can update later |
I doubt people are using it. Previously, it was merged: But IMHO, separating per backend is easier than downloading a 1GB file. As you say, we can improve later on if it hurts for some reason. |
#6482 should solve the artifact naming conflict. It will upload multiple smaller artifacts instead of one big one, which I think is more useful for most users and developers. |
…rganov#6456) * CI: Update actions/checkout to v4 * CI: Update actions/setup-python to v5 * CI: Update actions/upload-artifact to v4
A bit of CI maintenance, which updates the following actions to their latest versions:
For each, the main change is an update from Node 16 LTS to Node 20 LTS.
If preferred, I can add a Dependabot configuration which opens these PRs automatically in the future (in another PR).