Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bench: fix Resource not accessible by integration on PR event #6393

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

phymbert
Copy link
Collaborator

Context

Facing Resource not accessible by integration on Benchmark workflow on PR created from forks, example:

This is expected according to the github documentation, the GITHUB_TOKEN has read permission on PR from fork.

Change

Switch trigger event from pull_request to pull_request_target.

Explained on github documentation:

For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission

As we need write permission for commit status and and PR comment.

@phymbert phymbert marked this pull request as draft March 30, 2024 07:47
@phymbert phymbert requested a review from ggerganov March 30, 2024 08:30
@phymbert phymbert marked this pull request as ready for review March 30, 2024 08:30
@phymbert
Copy link
Collaborator Author

phymbert commented Mar 30, 2024

@ggerganov Georgi, let's try this approach, probably need to change some variables inside the workflow later on. But need to be merged first

@ggerganov ggerganov merged commit 37e7854 into ggerganov:master Mar 30, 2024
21 checks passed
@phymbert phymbert deleted the hp/ci/bench branch March 30, 2024 10:45
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants