Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama: remove redundant reshape in build_kv_store #6369

Merged
merged 2 commits into from
Mar 29, 2024
Merged

llama: remove redundant reshape in build_kv_store #6369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f0ae7
llama: remove redundant reshape in build_kv_store
danbev Mar 28, 2024
d907f70
llama : add assert
ggerganov Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llama.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5523,8 +5523,8 @@ static void llm_build_kv_store(
GGML_ASSERT(kv.size == n_ctx);

// compute the transposed [n_tokens, n_embd] V matrix
struct ggml_tensor * v_cur_t = ggml_transpose(ctx, ggml_reshape_2d(ctx, v_cur, n_embd_v_gqa, n_tokens));
//struct ggml_tensor * v_cur_t = ggml_transpose(ctx, v_cur); // TODO: reshape above is likely not needed
assert(v_cur->ne[0] == n_embd_v_gqa && v_cur->ne[1] == n_tokens);
struct ggml_tensor * v_cur_t = ggml_transpose(ctx, v_cur);
ggerganov marked this conversation as resolved.
Show resolved Hide resolved
cb(v_cur_t, "v_cur_t", il);

struct ggml_tensor * k_cache_view = ggml_view_1d(ctx, kv.k_l[il], n_tokens*n_embd_k_gqa,
Expand Down
Loading