Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC compile errors #5643

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix MSVC compile errors #5643

merged 1 commit into from
Mar 8, 2024

Conversation

uextm
Copy link
Contributor

@uextm uextm commented Feb 21, 2024

MSVC gives the following error with the existing macros: Error C2059 : syntax error: ','

This patch adds ## as a prefix to __VA_ARGS__ to address this error.

MSVC gives the following error with the existing macros:
`Error C2059 : syntax error: ','`

This patch adds `##` as a prefix to `__VA_ARGS__` to address this error.
@uextm uextm closed this Mar 8, 2024
@uextm uextm deleted the patch-1 branch March 8, 2024 02:20
@uextm uextm restored the patch-1 branch March 8, 2024 02:24
@uextm uextm reopened this Mar 8, 2024
@ggerganov ggerganov merged commit 581ed5c into ggerganov:master Mar 8, 2024
114 checks passed
@uextm uextm deleted the patch-1 branch March 8, 2024 14:52
hazelnutcloud pushed a commit to hazelnutcloud/llama.cpp that referenced this pull request Mar 10, 2024
MSVC gives the following error with the existing macros:
`Error C2059 : syntax error: ','`

This patch adds `##` as a prefix to `__VA_ARGS__` to address this error.
NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 12, 2024
MSVC gives the following error with the existing macros:
`Error C2059 : syntax error: ','`

This patch adds `##` as a prefix to `__VA_ARGS__` to address this error.
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
MSVC gives the following error with the existing macros:
`Error C2059 : syntax error: ','`

This patch adds `##` as a prefix to `__VA_ARGS__` to address this error.
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
MSVC gives the following error with the existing macros:
`Error C2059 : syntax error: ','`

This patch adds `##` as a prefix to `__VA_ARGS__` to address this error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants