common: use enums for sampler types #5418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring of the code related to working with sampler names. Its main purpose is to prepare the code for adding
sampling-seq
to the server.string_split
andsampler_types_from_names
. It was done because the latter function will also make parsing the sampler array for the server much easier.llama_sampling_order_print
tosampler_type_to_name_string
. It makes it less likely to miss something and alsosampler_type_to_name_string
may be used in theget_formated_generation
for the server.--samplers
now shows the actual default value, not the hard-coded example.